fix(hig): move Save as Favorite off Cmd+D to free the system Don't Save accelerator (#1490)#1516
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12b1783982
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .truncateTable: KeyCombo(key: "delete", option: true, isSpecialKey: true), | ||
| .previewFKReference: KeyCombo(key: "space", isSpecialKey: true), | ||
| .saveAsFavorite: KeyCombo(key: "d", command: true), | ||
| .saveAsFavorite: KeyCombo(key: "d", command: true, control: true), |
There was a problem hiding this comment.
This new default still collides with a macOS-provided text-editing shortcut: Control-Command-D is documented by Apple as “Show or hide the definition of the selected word.” In TablePro this menu item is installed globally via TableProApp’s Query menu, so while editing SQL or other text with canSaveAsFavorite true, the app action can take precedence over the standard Lookup behavior. Since this change is intended to move the action away from system accelerators, please choose a shortcut that is not already used by macOS text editing.
Useful? React with 👍 / 👎.
1 participant
Part of #1490 (keyboard, focus, accessibility). Menus & shortcuts.
macOS reserves Cmd+D for the 'Don't Save' button in save-changes dialogs (NSAlert maps it automatically). Save as Favorite was bound to Cmd+D, which shadows that system accelerator in the exact moment a user tries to dismiss a save dialog. This moves the default to Cmd+Control+D (Cmd+Option+D is the system Toggle Dock and Cmd+Shift+D is Duplicate Row, both taken). Rebindable in Settings, Keyboard.
Lint clean, style gate clean.